search

openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

[DISCUSS] Transferring this repository #46

Closed shimamoto closed 5 years ago

shimamoto commented 5 years ago

I am looking to contribute this library to openzipkin organization. Current organization is a corporate account, so that I cannot invite users who don't work for the company to organization. One of my expectations in such an effort is to improve maintenance operation. It would be great to move to openzipkin-contrib.

cc @adriancole @takezoe

codefromthecrypt commented 5 years ago

I'm in favor of this. While there is a potential future where https://github.com/SmartThingsOSS/smartthings-brave-scala becomes contrib or otherwise, I don't think contrib is the right place to choose one solution. Especially, play-zipkin-tracing is a healthy project people use and we should make it easier for people to help with it.

takezoe commented 5 years ago

Also already there is brave-akka (https://github.com/openzipkin-contrib/brave-akka) in openzipkin-contrib organization. This library overlaps with play-zipkin-tracing in Akka tracing, but I think that still opezipkin-contrib is a good place to contribute play-zipkin-tracing.

shimamoto commented 5 years ago

ah, so how about moving play tracing into openzipkin-contrib as a single project?

codefromthecrypt commented 5 years ago

@openzipkin/core does anyone have feedback against moving this to openzipkin-contrib? If you are in favor please thumbsup.

codefromthecrypt commented 5 years ago

whoops that alias doesn't work outside our org :) manually doing it. cc @abesto @basvanbeek @devinsba @eirslett @jcarres-mdsol @jcchavezs @llinder @michaelsembwever @shakuzen @zeagord

codefromthecrypt commented 5 years ago

and most recently @jeqo

codefromthecrypt commented 5 years ago

ok we have sufficient interest. Can someone add me as a repo owner then I can move it retaining the same committers as we have now

shimamoto commented 5 years ago

@adriancole Unfortunately, I cannot add you to current organization because of a corporate account. I think there are basically two options:

One, I transfer this repository to openzipkin-contrib organization. Two, you create a new repository on openzipkin-contrib organization, and I can import a Git repository only.

codefromthecrypt commented 5 years ago

I just gave you rights on openzipkin-contrib so you can do the transfer. Thanks!

On Fri, Mar 22, 2019 at 2:40 PM takako shimamoto notifications@github.com wrote:

@adriancole https://github.com/adriancole Unfortunately, I cannot add you to current organization because of a corporate account. I think there are basically two options:

One, I transfer this repository to openzipkin-contrib organization. Two, you create a new repository on openzipkin-contrib organization, and I can import a Git repository only.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bizreach/play-zipkin-tracing/issues/46#issuecomment-475510718, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD614MdHS_vOeym2MQ76KWrUGpnpr-Vks5vZHrdgaJpZM4b7uKD .

shimamoto commented 5 years ago

Done!