openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

Change project organization to io.zipkin.brave.play #47

Closed shimamoto closed 5 years ago

shimamoto commented 5 years ago

There are some remaining places that use the old organization. Those places are README and examples. We could completely remove the old organization in the next release.

codefromthecrypt commented 5 years ago

food for thought @llinder's work here is io.zipkin.brave.ratpack https://github.com/openzipkin-contrib/brave-ratpack/blob/master/pom.xml#L20

takezoe commented 5 years ago

Can we use io.zipkin.brave.play as the group id (organization in sbt) and the base package name? Also we need permission to publish artifacts to Sonatype.

codefromthecrypt commented 5 years ago

sounds good on maven group ID. you might want to consider "brave.play" on package name so that in case this is moved to ASF we don't have to rename the packages (group id is a smaller matter).

on sonatype can you request to be added here? It has been my experience that they always just add people who ask :) https://issues.sonatype.org/browse/OSSRH-16669

On Mon, Mar 25, 2019 at 11:02 PM Naoki Takezoe notifications@github.com wrote:

Can we use io.zipkin.brave.play as the group id (organization in sbt) and the base package name? Also we need permission to publish artifacts to Sonatype.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

shimamoto commented 5 years ago

Fixed. Thanks for the jira link! I'll request access before releasing the next version.

takezoe commented 5 years ago

@adriancole Do you mean that we can use package names other than org.apache.* even after we move to ASF?

codefromthecrypt commented 5 years ago

@adriancole https://github.com/adriancole Do you mean we can use package names other than org.apache.* even after we move to ASF?

yes

takezoe commented 5 years ago

@adriancole I got it. I had assumed that we must use org.apache.* as package name due to the rules of ASF, but there were no such rules. Thanks!

codefromthecrypt commented 5 years ago

thanks very much