search

openzipkin-contrib / play-zipkin-tracing

Provides distributed tracing for Play Framework and Akka using Zipkin.
Apache License 2.0
48 stars 19 forks source link

NullPointerException #52

Open simao opened 5 years ago

simao commented 5 years ago

I am getting the following error when using play-zipkin-tracing: 

[info]   java.lang.NullPointerException: context == null
[info]   at brave.Tracer.joinSpan(Tracer.java:185)
[info]   at brave.play.ZipkinTraceServiceLike.toSpan(ZipkinTraceServiceLike.scala:173)
[info]   at brave.play.ZipkinTraceServiceLike.toSpan$(ZipkinTraceServiceLike.scala:168)

toSpan uses joinSpan https://github.com/openzipkin-contrib/play-zipkin-tracing/blob/master/play-zipkin-tracing/core/src/main/scala/brave/play/ZipkinTraceServiceLike.scala#L168

But the problem is it also passes contextOrFlags.context() to joinSpan, which might be null if no context was extracted.

Would using nextSpan(contextOrFlags), as suggested in brave, be a better choice?

https://github.com/openzipkin/brave/blob/master/brave/src/main/java/brave/Tracer.java#L160