Set the annotation name to the same as the event name if the attributes are empty

openzipkin-contrib / zipkin-otel

Reporters and collectors for use in OpenTelemetry

Apache License 2.0

5 stars 2 forks source link

Set the annotation name to the same as the event name if the attributes are empty #16

Closed making closed 2 months ago

making commented 2 months ago

Following "OpenTelemetry to Zipkin Transformation", I set the annotation name, but I found that if event's attributes is empty, it is meaningless and inconvenient as attached. In this PR, if attributes is empty, the event name is used as the annotation name.

codefromthecrypt commented 2 months ago

some test fuzz yet

making commented 2 months ago

oops, fixed