search

openzipkin-contrib / zipkin-otel

Reporters and collectors for use in OpenTelemetry
Apache License 2.0
5 stars 2 forks source link

Support adding static resource attributes on the encoder side #18

Closed making closed 2 months ago

making commented 2 months ago

This pull request adds a way to add static resource attributes on the encoder side. Related to #14, resource attributes are typically static and do not depend on a span.

For example, Spring Boot provides management.opentelemetry.resource-attributes.* properties to add resource attributes for Otel SDK. This pr will provide the feature parity of this capability for Brave. https://github.com/spring-projects/spring-boot/blob/aba22547ee56606c815ecb1ef57cee82e9005ed9/spring-boot-project/spring-boot-actuator-autoconfigure/src/main/java/org/springframework/boot/actuate/autoconfigure/opentelemetry/OpenTelemetryAutoConfiguration.java#L74-L91

codefromthecrypt commented 2 months ago

maybe switch to builder style like our other things? Now's a good time I think as we will surely have more. We typically don't go with public ctors on things that end up with multiple fields to set.

you can look at things like https://github.com/openzipkin/zipkin-reporter-java/blob/bbe4d01cffc39d0814614057d126155449e9ea21/amqp-client/src/main/java/zipkin2/reporter/amqp/RabbitMQSender.java#L68-L173

making commented 2 months ago

Will do

making commented 2 months ago

Changed to the builder-style