search

openzipkin / b3-propagation

Repository that describes and sometimes implements B3 propagation
Apache License 2.0
541 stars 62 forks source link

Replace box drawing character with hyphen in header names in diagrams #19

Closed rmichela closed 6 years ago

rmichela commented 6 years ago

The use of box drawing characters in the header names tripped me up when copy/pasting from the readme into code. The box drawing character is close enough to a hyphen that it isn't obvious anything is wrong until strings fail to match and "not ascii character" exceptions start to throw.

I made this change to save a headache for the next person.

codefromthecrypt commented 6 years ago

very good catch. I think this came up in census as well. Thank you so much for fixing this!