openzipkin / brave-cassandra

Tracing instrumentation for Cassandra and the DataStax Java Driver
Apache License 2.0
12 stars 14 forks source link

Test failure: brave.cassandra.ITTracing.usesExistingTraceId #11

Closed shakuzen closed 5 years ago

shakuzen commented 6 years ago

When the build was updated so failsafe executed integration tests (see #10), a failure was revealed in brave.cassandra.ITTracing.usesExistingTraceId. I could reproduce this failure locally, so it seems like a genuine issue.

java.lang.AssertionError: 

Expecting:
 <[CLIENT]>
to contain only once:
 <[SERVER, CLIENT]>
but some elements were not found:
 <[SERVER]>

    at brave.cassandra.ITTracing.usesExistingTraceId(ITTracing.java:98)
codefromthecrypt commented 6 years ago

i believe this is because propagation is now disabled by default in TracingSession. might be wrong