search

openzipkin / brave-cassandra

Tracing instrumentation for Cassandra and the DataStax Java Driver
Apache License 2.0
12 stars 14 forks source link

Moves build to JDK 11 #19

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

This works around a problem in running the error-prone plugin under JDK 1.8. We don't need to support building with JDK 1.8 in this project.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.0:testCompile (default-testCompile) on project brave-instrumentation-cassandra-driver: Fatal error compiling: Error while executing the compiler. InvocationTargetException: ANNOTATION_PROCESSOR_MODULE_PATH -> [Help 1]
codefromthecrypt commented 5 years ago

note building != running. We compile to the corresponding target java version. Ex javac 11 can compile to 1.6 bytecode.

codefromthecrypt commented 5 years ago

failure is unrelated.. it is good that we got to a failure.

codefromthecrypt commented 5 years ago

rationale for dropping 1.8 is that it is ancient and not necessary, so spending time on it is questionable on this project.

I don't think any committers will care, but if they feel strongly we can resurrect 1.8 ability by changing the enforcer configuration (but not resurrecting error-prone unless someone wants to dump time there).