search

openzipkin / brave-cassandra

Tracing instrumentation for Cassandra and the DataStax Java Driver
Apache License 2.0
12 stars 14 forks source link

Java 8 Support #26

Closed jake-codes closed 5 years ago

jake-codes commented 5 years ago

Is it possible to have Java 8 supported for this project along with Java 11?

Lots of businesses are still using Java 8 because the official support for Cassandra came out just last year, I believe. Anyway, if their choice is between upgrading their Java (and doing all the regression testing, etc, to make sure there are no negative effects) or simply not using this project, many will likely choose to not use this, unfortunately.

codefromthecrypt commented 5 years ago

JDK (build) version is different than runtime version. We ship jars not source. Have you noticed a bytecode problem?

codefromthecrypt commented 5 years ago

for example, unless there's a bug in our config, this should match cassandra at Java 1.7

https://github.com/openzipkin/brave-cassandra/blob/master/pom.xml#L35-L37

jake-codes commented 5 years ago

Got it. Thanks a lot.

codefromthecrypt commented 5 years ago

no problem!