search

openzipkin / brave-cassandra

Tracing instrumentation for Cassandra and the DataStax Java Driver
Apache License 2.0
12 stars 14 forks source link

Makes manual deployment exactly the same as Travis #34

Closed codefromthecrypt closed 3 years ago

codefromthecrypt commented 3 years ago

Before, we had travis/publish.sh which took concerns such as checking Travis tags. Travis currently has conditions libraries and well-defined stages. This uses these features instead as it allows us a more simple relationship between what are release steps vs what are travis-specific.

codefromthecrypt commented 3 years ago

ps still trying to figure out why this isn't triggering on my PR..

codefromthecrypt commented 3 years ago

Lesson learned:

In the docker-java project, I took advantage of the implicit "test" phase, using the top-level "script" by default.

This doesn't work when adding conditions on the "test" phase. In this case, you have to override it entirely the same as if defining the job from scratch.

codefromthecrypt commented 3 years ago

I'm going to merge this, then make a fake pull request from my fork, to ensure the PR works on non-head branches.

codefromthecrypt commented 3 years ago

this works, except that the status of the "test" phase isn't reported back on the fork PR https://github.com/openzipkin/brave-cassandra/pull/35

https://travis-ci.org/github/openzipkin/brave-cassandra/builds/742193067