search

openzipkin / brave-cassandra

Tracing instrumentation for Cassandra and the DataStax Java Driver
Apache License 2.0
12 stars 14 forks source link

Uses Docker for Cassandra integration tests and fixes OSGi #45

Closed codefromthecrypt closed 3 years ago

codefromthecrypt commented 3 years ago

We ran into numerous problems relating to compilation and runtime of Cassandra. This uses Docker instead, notably building an image at runtime to test the tracing instrumentation.

This doesnt' work perfectly in failsafe, yet. Just raising it for feedback

cc @bsideup @anuraaga @reta @michaelsembwever @jeqo @jcchavezs

codefromthecrypt commented 3 years ago

think it works, now, let's see if GH actions agrees

codefromthecrypt commented 3 years ago

PS one of the motivations here is to implement https://github.com/openzipkin/brave-example with cassandra, where the "frontend" is an instrumented HTTP server that calls cassandra, and "backend" is cassandra itself. Right now, there's little visibility into this awesome project which literally instruments cassandra.

codefromthecrypt commented 3 years ago

weird..

Caused by: com.github.dockerjava.api.exception.NotFoundException: Status 404: {"message":"no such image: ghcr.io/openzipkin/zipkin-cassandra:2.23.0: No such image: ghcr.io/openzipkin/zipkin-cassandra:2.23.0"}
codefromthecrypt commented 3 years ago

"works on my laptop"

codefromthecrypt commented 3 years ago

not sure why the image isn't found in GH actions.. I'll nuke my local env later to make sure.

codefromthecrypt commented 3 years ago

@bsideup of course you were right on not being a great idea to do docker inspect as that's not free of implications. thanks!

codefromthecrypt commented 3 years ago

💋 @bsideup copy to container was way better. it is only 500k as brave minds its weight. no reason at all to bake an image first indeed!

reta commented 3 years ago

@adriancole just gave it a try on my local machine, works with no issues (as usually with TestContainers)