openzipkin / brave-karaf

Karaf integration and tests for Brave (java Zipkin tracer)
Apache License 2.0
7 stars 6 forks source link

Create Apache Karaf features for brave #1

Open codefromthecrypt opened 7 years ago

codefromthecrypt commented 7 years ago

From @cschneider on December 8, 2016 9:22

The first step for using brave in OSGi is already done by making the brave jars bundles. Still it can be a lot of effort to install all the bundles in OSGi. At least on Apache Karaf we can make this a lot easier by maintaining a feature repo file. This lists the bundles for the modules of brave and allows to install them using just a few commands or config settings in karaf.

See the feature file in my demo project for an example for an example.

We can manage these feature files either in karaf or in the source project. I trypically prefer to have them in the source project as then users are not limited to a certain brave version that comes with the karaf version. It also makes sure users can leverage the newest brave version as soon as it is out.

Of course managing the feature file at brave is problematic as the core brave developer will not test on OSGi. So I plan to also supply pax exam based tests that install the features and make sure they work

Copied from original issue: openzipkin/brave#291

codefromthecrypt commented 7 years ago

next steps are setup in nature. It will be exactly the same stuff that @devinsba and @llinder did with zipkin-aws. In fact, I'd copy/paste/find/replace from there as it will help a lot.

@cschneider can you copy/paste/find/replace https://github.com/openzipkin/zipkin-aws to here? main thing is to get the base pom exactly the same except for project name and group id stuff. Ex the group id is io.zipkin.brave.karaf here. This will involve circleci which is what we are now using for CI and publishing

On the note of publishing, can you please request your sonatype user get access here: https://issues.sonatype.org/browse/OSSRH-16669 You'll also need to create a bintray account https://bintray.com/openzipkin/maven/brave-karaf and I'll add you as a member so that you can publish to the release repo (which syncs to central)

ps not sure if @iocanel wants in on this action or not :)

cschneider commented 7 years ago

I have created the parent pom, the feature and a first test. Would be great if @iocanel or any other karaf people are willing to help maintain this.

codefromthecrypt commented 7 years ago

:clap:

iocanel commented 7 years ago

You can add me and see how it goes :-)

codefromthecrypt commented 7 years ago

/me winces