search

openzipkin / brave-karaf

Karaf integration and tests for Brave (java Zipkin tracer)
Apache License 2.0
7 stars 6 forks source link

Works around inheritance that results in an empty DEPENDENCIES file #39

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

org.apache:apache:21 sets maven-remote-resources-plugin in plugins, not pluginManagement This results in execution in the parent project, and a side effect of an empty DEPENDENCIES file in the assembly when packaged with the apache-release profile.

https://issues.apache.org/jira/browse/MPOM-218

This works around the problem by skipping at the parent level at the cost of having to un-skip it at every deployed child.

codefromthecrypt commented 5 years ago

I verified that now the package step doesn't result in a file like this:

$ cat brave-karaf-0.1.2/DEPENDENCIES  
// ------------------------------------------------------------------
// Transitive dependencies of this project determined from the
// maven pom organized by organization.
// ------------------------------------------------------------------

Brave Karaf (Parent)
codefromthecrypt commented 5 years ago

another approach could be to hack further our src/main/assemblies/source-release.xml file, but in a couple hours I could not figure out how to get it to exclude the DEPENDENCIES entry when building the zip.

codefromthecrypt commented 5 years ago

yet another approach is to do what some other projects are doing, and create a separate "distribution" module and walk around it there. I personally prefer not to create too much more bookkeeping as the "distribution" approach includes quite a lot of it..

Ex https://github.com/apache/incubator-edgent/blob/master/distribution/pom.xml https://github.com/apache/incubator-dubbo/tree/master/dubbo-distribution