search

openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.36k stars 713 forks source link

Add dubbo3 support #1364

Closed ShenFeng312 closed 1 year ago

ShenFeng312 commented 1 year ago

@jcchavezs

jcchavezs commented 1 year ago

Thanks for this. Let @shakuzen and me review the code and get back to you.

On Fri, 3 Mar 2023, 11:09 ShenFeng312, @.***> wrote:

@jcchavezs https://github.com/jcchavezs

— Reply to this email directly, view it on GitHub https://github.com/openzipkin/brave/pull/1364#issuecomment-1453282580, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYATAWNHE4PPKIMSX4Z3W2G7NRANCNFSM6AAAAAAVLUPTHM . You are receiving this because you were mentioned.Message ID: @.***>

jcchavezs commented 1 year ago

Overall looks good. Let's also ping @jeqo

ShenFeng312 commented 1 year ago

@shakuzen @jeqo

ShenFeng312 commented 1 year ago

Hi :) Any ideas when this will be merged? @jcchavezs @shakuzen @jeqo

jcchavezs commented 1 year ago

I will try to reach out @shakuzen to get some feedback.

jcchavezs commented 1 year ago

Let me get some other reviewers

ShenFeng312 commented 1 year ago

Let me get some other reviewers

OK~ thanks

ShenFeng312 commented 1 year ago

I will open a new PR to support this