openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.36k stars 714 forks source link

Support spring-webmvc for jakarta #1369

Open be-hase opened 1 year ago

be-hase commented 1 year ago

There is a change from spring boot3 (spring 6) to jakarta.servlet.

Currently, brave-instrumention-spring-webmvc only supports javax.servlet.

Are there any plans to support jakarta.servlet?

In the long run, I think spring users would be better off with micrometer tracing, but I think existing users would be happier with brave-instrumention-spring-webmvc as well.

marcingrzejszczak commented 1 year ago

Spring mvc natively supports micrometer observation. They work with micrometer tracing which has a brave bridge.

reta commented 1 year ago

On the side note

Are there any plans to support jakarta.servlet?

It is supported already https://github.com/openzipkin/brave/tree/master/instrumentation/servlet-jakarta

be-hase commented 1 year ago

It is supported already https://github.com/openzipkin/brave/tree/master/instrumentation/servlet-jakarta

servlet-jakarta is coresspond to servlet, not the jakarta version of spring-webmvc