search

openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.35k stars 714 forks source link

Removes all deprecated types and modules for Brave v6 #1395

Closed codefromthecrypt closed 6 months ago

codefromthecrypt commented 6 months ago

Removes all deprecated types and modules for Brave v6. This also removes any internal symbols not used as a result of that.

This is the first release to have no Zipkin dependency, so users should move to manage their own zipkin-reporter deps before or at the time of upgrading to Brave 6.0.

codefromthecrypt commented 6 months ago

I will change the version of this PR to 6.0.0-SNAPSHOT once 5.18 is cut (shortly)

codefromthecrypt commented 6 months ago

So brave no longer manages reporter versions, which is a good thing as then they cannot conflict. Brave is compatible with both zipkin-reporter 2.x and 3.x, but pinning the latter in the bom can make things complicated for old libraries. It is better to pin the reporter to whatever frameworks need. For example, otel pins 2.x at the moment.

codefromthecrypt commented 6 months ago

will confirm in brave-example prior to release