openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.36k stars 713 forks source link

Undeprecates propagation symbols for v6 interop #1396

Closed codefromthecrypt closed 9 months ago

codefromthecrypt commented 9 months ago

This undeprecates B3SinglePropagation and enforces at runtime that Propagation.Factory#get() must be implemented. I spot checked all the implementations on GitHub already do.

codefromthecrypt commented 9 months ago

ok I scraped github and raised PRs for all the known implementations of propagation. Most were things I did or copies of stuff @marcingrzejszczak made cc @shakuzen

After those projects merge, they will be safe to update into Brave 6 (#1395)

codefromthecrypt commented 9 months ago

Also, all PRs I mentioned on this issue are opened to allow editors to write to my branch. Not saying they will, but they can as necessary.

codefromthecrypt commented 9 months ago

I also released this to maven central as it seems there are a couple copies of brave w3c tracecontext (even if not the same impl as the one I wrote) https://central.sonatype.com/artifact/io.zipkin.contrib.brave-propagation-w3c/brave-propagation-tracecontext/versions https://github.com/openzipkin-contrib/brave-propagation-w3c