openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.35k stars 714 forks source link

ci: deploys bom separately to allow re-do on partial failure #1406

Closed codefromthecrypt closed 6 months ago

codefromthecrypt commented 6 months ago

Before, the bom project deployed only after the parent succeeded. This meant a timeout would prevent it from being deployed, even if the timeout was not critical. This deploys the bom independently so that such a situation doesn't cause us to have to re-cut a version.

This also fixes where we didn't actually use the release args in tests.

codefromthecrypt commented 6 months ago

this worked for reporter, proved by https://github.com/openzipkin/zipkin/pull/3683