Closed codefromthecrypt closed 9 months ago
hmm this seems unrelated
Error: Failures:
Error: ThreadLocalSpanClassLoaderTest.currentTracer_basicUsage_unloadable:35 class brave.propagation.ThreadLocalSpanClassLoaderTest$ExplicitTracerBasicUsage includes state that couldn't be garbage collected
Thanks for the look, folks!
This removes a dependency on
IpLiteral.detectFamily
from json writing, and adds a benchmark to make sure it doesn't hurt performance. While a nit, this clarifies that it has already happened, so that a proto encoder port will not think it needs to re-detect also.Before
After