search

openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.35k stars 714 forks source link

Instrumentation for Apache Thrift #1423

Open Yunie9 opened 4 months ago

Yunie9 commented 4 months ago

Are there plans to support Thrift RPC？Dubbo and gRPC is currently supported.

codefromthecrypt commented 4 months ago

instrumentation is only added once folks ask for it, and someone has time to implement it. Sometimes, not everything ends up here.. For example, it could be that thrift ends up with a brave module vs us having a thrift one.

The closest we have to thrift instrumentation right now is Armeria, which accepts the thrift protocol. In their case, due to API breaks between thrift versions, they end up needing to a different module per version of thrift. That is an unfortunate norm in libraries that don't ever release a semantic 1.0 version.

There's also a possibility someone has instrumented thrift, just not here. The next step is to get at least a few people interested as there is a maintenance cost for sure. Also, maybe check if someone at thrift is interested in hosting this or not.