search

openzipkin / brave

Java distributed tracing implementation compatible with Zipkin backend services.
Apache License 2.0
2.36k stars 713 forks source link

How to add a span of vertex to httpClient #836

Open liushunqiu opened 5 years ago

liushunqiu commented 5 years ago

How to add a span of vertex to httpClient

codefromthecrypt commented 5 years ago

I think very recent version of vert.x can have client tracing. I helped them test it but we haven't built it into brave yet.

liushunqiu commented 5 years ago

Hello, I am now integrating brave-instrumentation-vertx-web and brave-instrumentation-httpclient, then I request the interface, separate the application through eventbus in the interface, and then call the external interface through httpclient, that is, in vertx -web should have a span containing httpclient, but in zipkin, I only found 2 different spans, httpClient did not join the previous span~ thx

codefromthecrypt commented 5 years ago

is it your intention to use apachehttpclient or is it because vertx client is not traced?

On Wed, 28 Nov 2018, 12:51 liushunqiu <notifications@github.com wrote:

Hello, I am now integrating brave-instrumentation-vertx-web and brave-instrumentation-httpclient, then I request the interface, separate the application through eventbus in the interface, and then call the external interface through httpclient, that is, in vertx -web should have a span containing httpclient, but in zipkin, I only found 2 different spans, httpClient did not join the previous span~ thx

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/openzipkin/brave/issues/836#issuecomment-442287986, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61yM3wyd00TpGFGPP3Cr6tCWwmW85ks5uzewlgaJpZM4Y1X2u .

liushunqiu commented 5 years ago

Hello, trouble to check the attachment, the attachment has a description code vert.x2httpClient.zip

thx