search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
38 stars 63 forks source link

quickstart is grabbing the wrong version for external modules #112

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

As noticed by @zeagord, looks like the LATEST version is coming from zipkin, not from the module requested.. maybe there was a change upstream somewhere. cc @abesto 

$ curl -sSL https://zipkin.io/quickstart.sh | bash -s io.zipkin.aws:zipkin-autoconfigure-collector-kinesis:LATEST:module kinesis.jar
Thank you for trying OpenZipkin!

This installer is provided as a quick-start helper, so you can try Zipkin out
without a lengthy installation process.

Fetching version number of latest Zipkin release...
Downloading io.zipkin.aws:zipkin-autoconfigure-collector-kinesis:2.11.3:module to kinesis.jar...
https://dl.bintray.com/openzipkin/maven/io/zipkin/aws/zipkin-autoconfigure-collector-kinesis/2.11.3/zipkin-autoconfigure-collector-kinesis-2.11.3-module.jar -> https://dl.bintray.com/openzipkin/maven/io/zipkin/aws/zipkin-autoconfigure-collector-kinesis/2.11.3/zipkin-autoconfigure-collector-kinesis-2.11.3-module.jar
abesto commented 5 years ago

That sucks, sorry. Taking a look.

Update: right, it looks like this was intentional; for whatever reason I assumed that the modules and Zipkin server would have the same versions. Making that assumption go away now from the code.

Update 2: there's a slight issue; at the moment the script has no way of knowing which Bintray repo the artifact lives in. Looks like switching to another API endpoint (search by Maven artifact group + name), along with some extra checks, can work around this. (I'm half tempted to rewrite this in Python, it's getting rather complex for a shell script)

abesto commented 5 years ago

Should be fixed by #113.

zeagord commented 5 years ago

Thanks Zoltán.