openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
38 stars 63 forks source link

Fix #112: quickstart is grabbing the wrong version for external modules #113

Closed abesto closed 5 years ago

abesto commented 5 years ago

Had to change the API used here, since originally the script had no way of knowing which Bintray repo the artifact is published into. For example, the Maven artifact io.zipkin.aws:zipkin-autoconfigure-collector-kinesis lives in the zipkin-aws Bintray repo. The /search/packages/maven API does what we need, but can potentially return multiple matches (if the same artifact lives in multiple repositories). The added complexity is to protect against this case.