search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
38 stars 63 forks source link

[quickstart.sh] Fix aborting on failed tput under CI envs #115

Closed abesto closed 5 years ago

abesto commented 5 years ago

... or any other environment without a full-featured terminal. For example tput bold exits with status 1 under TERM=dumb. Since -e is set, this aborts the full script execution.

This should fix the issue reported in https://github.com/openzipkin/openzipkin.github.io/pull/114#issuecomment-419091732. @marcingrzejszczak do you have a way of running the script in your CI env from this branch? If you could verify it fixes the issue, it'd be much appreciated.

marcingrzejszczak commented 5 years ago

If you tell me how to run the fix from branch then sure ;)

marcingrzejszczak commented 5 years ago

What should I modify in curl -sSL https://zipkin.io/quickstart.sh | bash -s to do that?

abesto commented 5 years ago

curl -sSL https://raw.githubusercontent.com/openzipkin/openzipkin.github.io/fe358ff87f0a84adc86b374d4149814d38ac95e4/quickstart.sh | bash -s should do the trick.

abesto commented 5 years ago

Fix confirmed in Gitter, merging.