Make quickstart.sh compatible with Bash 3

openzipkin / openzipkin.github.io

content for https://zipkin.io

https://zipkin.io

Apache License 2.0

38 stars 63 forks source link

Make quickstart.sh compatible with Bash 3 #117

Closed shakuzen closed 5 years ago

shakuzen commented 5 years ago

A recent change (49e6083938c8f051c2b7500bdd265634f4fa86c8) moved to a Bash 4 only syntax, which caused the quickstart script to fail on Bash 3. This commit restores Bash 3 compatibility while hopefully still addressing the concern in the original commit.

SO reference: https://stackoverflow.com/questions/2264428/how-to-convert-a-string-to-lower-case-in-bash#comment56199987_18363058

Gitter report: https://gitter.im/openzipkin/zipkin-dev?at=5b99ed91f4bd1056ac56069e

Review requested from @abesto

shakuzen commented 5 years ago

Tested the changes locally with Bash 3.2.57 and it works (whereas it failed before)

$ bash --version
GNU bash, version 3.2.57(1)-release (x86_64-apple-darwin16)
Copyright (C) 2007 Free Software Foundation, Inc.