Closed jeqo closed 5 years ago
Looks legit, thanks for updating the dependencies as well!
https://github.com/envygeeks/jekyll-docker/blob/master/README.md#dependencies confirms the Docker container correctly updates dependencies to whatever we have in Gemfile.lock
, so that's great.
We might possibly save some build time / headaches by specifying the Docker tag corresponding to the version of Jekyll we're using (via https://pages.github.com/versions.json), but then that needs to be regularly maintained. Or a wrapper script needs to parse that JSON and somehow pass it in (Compose does ENV interpolation on the image name, right?) Either way, that's a lot of thinking for very little gain, so whatevs.
👍
thank ye
In order to test the site without installing Ruby dependencies, a docker-compose configuration is provided to make this easier.