search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
39 stars 64 forks source link

chore: adds zipkin-api as submodule and removes it from the old process. #137

Closed jcchavezs closed 5 years ago

jcchavezs commented 5 years ago

This PR includes zipkin-api as submodule in order to make sure every publish includes the latest version of it. This btw also fixes the issue that a horrendous trace example was shown in the swagger ui.

Ping @openzipkin/core

codefromthecrypt commented 5 years ago

thanks for fixing the broken window!

On Fri, Aug 2, 2019 at 8:12 PM José Carlos Chávez notifications@github.com wrote:

This PR includes zipkin-api as submodule in order to make sure every publish includes the latest version of it. This btw also fixes the issue that a horrendous trace example was shown in the swagger ui.

Ping @openzipkin/core https://github.com/orgs/openzipkin/teams/core

You can view, comment on, or merge this pull request online at:

https://github.com/openzipkin/openzipkin.github.io/pull/137 Commit Summary

  • chore: adds zipkin-api as submodule and removes it from the old process.

File Changes

Patch Links:

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/137?email_source=notifications&email_token=AAAPVV423X2FQDW465M2EPTQCQQDZA5CNFSM4II5F6NKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HDBOWAQ, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV6CVIH2HLFXTYO7GU3QCQQDZANCNFSM4II5F6NA .

jcchavezs commented 5 years ago

I tested this locally and also made sure we have the required files in zipkin-api in CI. I am merging this.