search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
39 stars 61 forks source link

revert: zipkin-api is being published automatically so no more submodules #144

Closed jcchavezs closed 4 years ago

jcchavezs commented 4 years ago

After a chat with @abesto for the sake of less maintenance complexity wewill keep the old flow (zipkin-api publishing itself) so we don't need the submodule approach anymore.

Ping @adriancole

codefromthecrypt commented 4 years ago

cool.. maybe remind how https://zipkin.io/zipkin-api/#/default ends up mounted, if not this way

jcchavezs commented 4 years ago

It is being published directly from zipkin-api repository. I need to fix that publishing as well.

José Carlos Chávez

man. 26. aug. 2019 kl. 02:11 skrev Adrian Cole notifications@github.com:

cool.. maybe remind how https://zipkin.io/zipkin-api/#/default ends up mounted, if not this way

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/144?email_source=notifications&email_token=AAXOYAQI3MK4E4WCVVCCLKDQGMNRVA5CNFSM4IPKBLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5C6YCQ#issuecomment-524676106, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXOYASW4MGSE24OKO2OE5TQGMNRVANCNFSM4IPKBLMQ .

codefromthecrypt commented 4 years ago

I mean the URL forwarding of https://zipkin.io/zipkin-api/#/default to whatever is the result of that publishing.. or if you mean that publishing pushed content to this repo?

sorry really I just forget how this works.

On Mon, Aug 26, 2019 at 3:28 PM José Carlos Chávez notifications@github.com wrote:

It is being published directly from zipkin-api repository. I need to fix that publishing as well.

José Carlos Chávez

man. 26. aug. 2019 kl. 02:11 skrev Adrian Cole notifications@github.com:

cool.. maybe remind how https://zipkin.io/zipkin-api/#/default ends up mounted, if not this way

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/openzipkin/openzipkin.github.io/pull/144?email_source=notifications&email_token=AAXOYAQI3MK4E4WCVVCCLKDQGMNRVA5CNFSM4IPKBLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5C6YCQ#issuecomment-524676106 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAXOYASW4MGSE24OKO2OE5TQGMNRVANCNFSM4IPKBLMQ

.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/144?email_source=notifications&email_token=AAAPVVYAA6RFSIHDLL3NJ33QGOA3FA5CNFSM4IPKBLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5DQ5UA#issuecomment-524750544, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVVY6FNKCCD2QYDLXFPTQGOA3FANCNFSM4IPKBLMQ .

jcchavezs commented 4 years ago

So the current status is that https://zipkin.io/zipkin-api/ is published by https://github.com/openzipkin/zipkin-api automatically (configured in the settings of https://github.com/openzipkin/zipkin-api) so whatever is under /zipkin-api is not controlled by this repo that is why we don't need the submodule thing anymore. Although this is counter intuitive, @abesto and I agree this is easier to maintain. I think i could drop a line about this in the readme.

codefromthecrypt commented 4 years ago

sg about a "how this works" section

codefromthecrypt commented 4 years ago

merging, would appreciate a "how this works" after the fact

codefromthecrypt commented 4 years ago

hmm the api listed is super old https://zipkin.io/zipkin-api/zipkin2-api.yaml doesnt even have autocomplete endpoints https://github.com/openzipkin/zipkin-api/blob/master/zipkin2-api.yaml

codefromthecrypt commented 4 years ago

@jcchavezs do you have cycles to fix the publishing?

jcchavezs commented 4 years ago

Yes I will check it.

José Carlos Chávez

fre. 27. sep. 2019 kl. 09:09 skrev Adrian Cole notifications@github.com:

@jcchavezs https://github.com/jcchavezs do you have cycles to fix the publishing?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/144?email_source=notifications&email_token=AAXOYAX2LU2AACOIZ64G4CDQLWWTHA5CNFSM4IPKBLM2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7X7LKA#issuecomment-535819688, or mute the thread https://github.com/notifications/unsubscribe-auth/AAXOYAV5QVEN3CJEIMB56NDQLWWTHANCNFSM4IPKBLMQ .