search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
39 stars 64 forks source link

Add a community supported tracer zipkin-clj (Clojure) #154

Closed sskorokhodov closed 4 years ago

sskorokhodov commented 4 years ago

Hi, Here is a Clojure library for tracing. It's Zipkin oriented but theoretically can be used with other tracing systems. Please tell me if there are any special requirements for a library to get into the list of supported tracers.

codefromthecrypt commented 4 years ago

Thanks. I looked at the code and it looks neat. I once did some clojure myself (back in jclouds days). I would recommend not mentioning OpenTracing on your README as your code is not using OpenTracing, and also OpenTracing itself is deprecated.

Your impl looks more similar in model and features to zipkin-go zipkin-php and brave. There are some features you might want to consider supporting and we can chat more here https://gitter.im/openzipkin/zipkin

meanwhile, thanks for creating this and notifying us!

sskorokhodov commented 4 years ago

Thank you for your time!

I'll remove mentioning OpenTracing, as you suggested. I'll also be glad to discuss more features to support in the future.