search

openzipkin / openzipkin.github.io

content for https://zipkin.io
https://zipkin.io
Apache License 2.0
39 stars 64 forks source link

list zipkin-go-opentracing as stand-alone option #43

Closed basvanbeek closed 8 years ago

basvanbeek commented 8 years ago

Even though zipkin-go-opentracing in combination with Go kit is a really good option (I highly recommend going this route) the tracing library itself is fully OpenTracing API compatible and can easily be used in other frameworks or roll your own environments. closes #42

codefromthecrypt commented 8 years ago

Thanks, Bas!

basvanbeek commented 8 years ago

@adriancole should this change be reflected instantly? it's not showing up for me...

codefromthecrypt commented 8 years ago

weird.. it should have...

On Mon, Aug 29, 2016 at 5:38 PM, Bas van Beek notifications@github.com wrote:

@adriancole https://github.com/adriancole should this change be reflected instantly? it's not showing up for me...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/43#issuecomment-243079284, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61_Ul1hsiKInV79nPD2URgyjWzE4zks5qkqh9gaJpZM4JvR_d .

codefromthecrypt commented 8 years ago

There was a YAML syntax error on line 99 column 3 in _data/existing_instrumentations.yml: did not find expected key while parsing a block mapping. For more information, seehttps://help.github.com/articles/page-build-failed- invalid-yaml-in-data-file.

On Mon, Aug 29, 2016 at 6:12 PM, Adrian Cole adrian.f.cole@gmail.com wrote:

weird.. it should have...

On Mon, Aug 29, 2016 at 5:38 PM, Bas van Beek notifications@github.com wrote:

@adriancole https://github.com/adriancole should this change be reflected instantly? it's not showing up for me...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/43#issuecomment-243079284, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61_Ul1hsiKInV79nPD2URgyjWzE4zks5qkqh9gaJpZM4JvR_d .

basvanbeek commented 8 years ago

my bad... fixed the issue and merged

codefromthecrypt commented 8 years ago

thanks for fixing!