Closed abesto closed 6 years ago
Possible alternative to the current artifact notation: we could define LATEST
as the version to mean the latest version, and include the version in the artifact definition. So instead of
./quickstart.sh io.zipkin.java:zipkin-autoconfigure-collector-kafka10:module kafka10.jar
One would write
./quickstart.sh io.zipkin.java:zipkin-autoconfigure-collector-kafka10:LATEST:module kafka10.jar
This has the advantages of matching the Gradle artifact notation more closely, as well as allowing use of non-latest versions (you could write, say, 2.4.0
instead of LATEST
). All this at the cost of a slightly longer command.
Want?
Will be pasted anyway.. want!
On 28 Nov 2017 5:18 am, "Zoltán Nagy" notifications@github.com wrote:
Possible alternative to the current artifact notation: we could define LATEST as the version to mean the latest version. So instead of
./quickstart.sh io.zipkin.java:zipkin-autoconfigure-collector-kafka10:module kafka10.jar
One would write
./quickstart.sh io.zipkin.java:zipkin-autoconfigure-collector-kafka10:LATEST:module kafka10.jar
This has the advantages of matching the Gradle artifact notation more closely, as well as allowing use of non-latest versions (you could write, say, 2.4.0 instead of LATEST). All this at the cost of a slightly longer command.
Want?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/94#issuecomment-347331080, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61_-N3E0_rQgRqtcTYmR85sswoNkBks5s6ycMgaJpZM4QsQ-H .
It's ready to go I think.
thanks! will update the readme PR
@abesto I just tried this on OSX and got the following:
$ curl -sSL https://zipkin.io/quickstart.sh | bash -s
Thank you for trying OpenZipkin!
This installer is provided as a quick-start helper, so you can try Zipkin out
without a lengthy installation process.
bash: line 177: ${artifact_version,,}: bad substitution
Thanks for reporting! At first glance it looks like a bash version issue. I'll fix up the script to work on the osx default bash version (or whatever else this turns out to be)
On Nov 29, 2017 1:42 PM, "Tommy Ludwig" notifications@github.com wrote:
@abesto https://github.com/abesto I just tried this on OSX and got the following:
$ curl -sSL https://zipkin.io/quickstart.sh | bash -s Thank you for trying OpenZipkin!
This installer is provided as a quick-start helper, so you can try Zipkin out without a lengthy installation process.
bash: line 177: ${artifact_version,,}: bad substitution
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/openzipkin/openzipkin.github.io/pull/94#issuecomment-347849142, or mute the thread https://github.com/notifications/unsubscribe-auth/AADqTlCpYMM8n20aJsTvged16x0s7r9Pks5s7VEsgaJpZM4QsQ-H .
@shakuzen I've uploaded a version that works on the machine where I managed to reproduce the issue (openzipkin/openzipkin.github.io@d114d9a). It'd be great if you could re-run the same command you used originally and let me know the results.
@abesto works well now. thank you for the quick turnaround!
As discussed in #93. Example session: