search

openzipkin / zipkin-api

Zipkin's language independent model and HTTP Api Definitions
https://zipkin.io/zipkin-api/
Apache License 2.0
59 stars 32 forks source link

Removes the TopBar form #103

Closed codefromthecrypt closed 7 months ago

codefromthecrypt commented 7 months ago

This removes the TopBar form, which removes any problems around it. Our doc page is only for our current API.

Note, this doesn't need any custom build to accomplish, just a (non-intuitive) change to swagger-initializer.js. I found out about this by searching issues in github and several are doing the same thing.

As this change is against the gh-pages branch, I can't also update build-bin/README.md on master. I'll do that in a separate PR once it is verified to fix the issue.

Later, we can make GH automation to regenerate the dist by unzipping the swagger dist overwriting everything except our IDL and swagger-initializer.js.

Before: Screenshot 2024-03-03 at 11 16 44

Now: Screenshot 2024-03-03 at 11 17 31

codefromthecrypt commented 7 months ago

@openzipkin/ui fyi as we have very little folks doing close looks at any UI change lately, I'm becoming more and more feature pessimistic. Anything we can disable is better as there are an army of vulnerability finding people out there, and it is hugely time consuming to answer them.

codefromthecrypt commented 7 months ago

thanks for the review @anuraaga!