search

openzipkin / zipkin-api

Zipkin's language independent model and HTTP Api Definitions
https://zipkin.io/zipkin-api/
Apache License 2.0
59 stars 32 forks source link

Adds ERROR constant for annotation.value and binaryannotation.key #18

Closed codefromthecrypt closed 8 years ago

codefromthecrypt commented 8 years ago

This adds an error constant used to flag spans as such.

See https://github.com/openzipkin/zipkin/issues/1140

virtuald commented 8 years ago

If there's an 'error' annotation, should there be a 'warning' annotation too?

yurishkuro commented 8 years ago

@virtuald this might be of interest: http://dave.cheney.net/2015/11/05/lets-talk-about-logging. Basically, it argues that most log levels are an anti-pattern.

virtuald commented 8 years ago

I have mixed feelings about that article.

codefromthecrypt commented 8 years ago

since it takes a bit of effort to try and get instrumentation to use any new annotations, and this is the authoritative definition of core, I'd argue for only "error" at the moment.

Error is much harder hitting, and explains more about latency than warning I think, yet doesn't prevent us from doing warning later if it becomes popular.

SG?

virtuald commented 8 years ago

Sure.

codefromthecrypt commented 8 years ago

clarified docs based on comments