search

openzipkin / zipkin-api

Zipkin's language independent model and HTTP Api Definitions
https://zipkin.io/zipkin-api/
Apache License 2.0
59 stars 32 forks source link

Moves project build to ASF infrastructure #63

Closed jeqo closed 5 years ago

jeqo commented 5 years ago

This moves off non-ASF things including repositories, deployment processes, license headers etc. It creates the same changes done in brave-cassandra.

codefromthecrypt commented 5 years ago

I will wait until the other repo settles before making similar comments here. thanks for the start, Jorge!

On Sat, Apr 20, 2019, 7:00 PM Jorge Quilcate Otoya notifications@github.com wrote:

This moves off non-ASF things including repositories, deployment processes, license headers etc. It creates the same changes done in brave-cassandra.

You can view, comment on, or merge this pull request online at:

https://github.com/apache/incubator-zipkin-api/pull/63 Commit Summary

  • chore: remove wrapper jar and update script

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/apache/incubator-zipkin-api/pull/63, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV2VMQSIJDS6HP746DTPRLSULANCNFSM4HHJLZ6A .

codefromthecrypt commented 5 years ago

you will want to delete build-support and .settings.xml as they are no longer valid

codefromthecrypt commented 5 years ago

we'll have to do the jenkins test later as until the file is merged we can't check https://builds.apache.org/job/incubator-zipkin-api

codefromthecrypt commented 5 years ago

also remove out-of-date RELEASE.md

codefromthecrypt commented 5 years ago

I ran this from your branch

$ GPG_TTY=$(tty) ./mvnw clean install -Papache-release

I think this isn't what we want.. it is probably better to cherry-pick files in this repo as there's no build step:

± |jeqo-apachify ✓| → jar -tvf target//apache-zipkin-api-incubating-0.2.1-SNAPSHOT-source-release.zip
     0 Sun Apr 21 10:10:06 JST 2019 zipkin-api-0.2.1-SNAPSHOT/
     0 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/thrift/
     0 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/
     0 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/javadoc/
     0 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/
     0 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/etc/
     0 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/main/
     0 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/main/assemblies/
 20678 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/zipkin2-api.yaml
  1597 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/validate.js
   263 Sun Apr 21 10:10:06 JST 2019 zipkin-api-0.2.1-SNAPSHOT/DEPENDENCIES
   170 Sun Apr 21 10:10:06 JST 2019 zipkin-api-0.2.1-SNAPSHOT/NOTICE
 11357 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/LICENSE
   413 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/CONTRIBUTING.md
  1726 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/.settings.xml
  1126 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/publish-snapshot.sh
 11223 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/pom.xml
  1470 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/go-offline.sh
 16262 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/zipkin-api.yaml
  1725 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/trigger-publish.sh
    79 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/javadoc/README.md
    40 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/.travis.yml
   735 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/README.md
  1049 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/publish-stable.sh
  9777 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/zipkin.proto
  1266 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/thrift/zipkinDependencies.thrift
   559 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/package.json
  1284 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/build-support/pom-no-crossmodule-dependencies.xsl
   756 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/etc/header.txt
  4354 Sun Apr 21 10:07:58 JST 2019 zipkin-api-0.2.1-SNAPSHOT/src/main/assemblies/source-release.xml
 19522 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/thrift/zipkinCore.thrift
  1136 Tue Apr 16 15:11:20 JST 2019 zipkin-api-0.2.1-SNAPSHOT/RELEASE.md

Ex. only take the thrift directory, LICENSE, README, .yaml and .proto wdyt?

codefromthecrypt commented 5 years ago

@jeqo mind if I help with this?

codefromthecrypt commented 5 years ago

@jeqo give this a whirl then squash merge if works for ya! I think it is good

codefromthecrypt commented 5 years ago

once merged, click https://builds.apache.org/job/incubator-zipkin-api/build?delay=0

codefromthecrypt commented 5 years ago

clicking while @jeqo finds his path to karma