Fixes three Zipkin v2 swagger2 datatypes

openzipkin / zipkin-api

Zipkin's language independent model and HTTP Api Definitions

https://zipkin.io/zipkin-api/

Apache License 2.0

59 stars 32 forks source link

Fixes three Zipkin v2 swagger2 datatypes #94

Closed philipbawn closed 8 months ago

philipbawn commented 3 years ago

This PR allows some client generators (such as nswag) to select the correct data type for microseconds when either:

querying for spans, or
de-serializing timestamps in annotations

This PR author is not sure if all client or server generators behave the same. For those that have never queried for a long span and weren't otherwise having problems this could break something somewhere for someone even though it improves zipkin-api.

philipbawn commented 3 years ago

I don't think maven likes the yaml comments unless it is the license year that is the problem. Also I read the contributor instructions, is there a more appropriate branch to PR against?

Thanks, Philip

devinsba commented 3 years ago

You'll just want to update the end date on the license header. Sorry, this isn't documented because it only happens once a year.