search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

AWS Propagation Incompatible with Brave 5.6 #118

Closed pettyjamesm closed 5 years ago

pettyjamesm commented 5 years ago

Changes in https://github.com/openzipkin/brave/pull/846 made HexCodec.writeHexByte package-private and therefore no longer accessible from AWSPropagation. It also added more efficient access to string span / trace id values which should probably be used to benefit from the cached id string values.

codefromthecrypt commented 5 years ago

good catch. we do try to make comments when we add things to internal types for external dependencies. in this case might be best to copy the old class into a internal or package protected type here.

in any case it should have been shaded.. apologies!

On Mon, Dec 17, 2018, 11:58 PM James Petty <notifications@github.com wrote:

Changes in openzipkin/brave#846 https://github.com/openzipkin/brave/pull/846 made HexCodec.writeHexByte package-private and therefore no longer accessible from AWSPropagation. It also added more efficient access to string span / trace id values which should probably be used to benefit from the cached id string values.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/issues/118, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61znW_wihLPg0plW4bsXdzDDfaAL1ks5u578MgaJpZM4ZWovc .

codefromthecrypt commented 5 years ago

https://github.com/openzipkin/zipkin-aws/pull/119 sorry about this!

pettyjamesm commented 5 years ago

Not a problem at, glad the fix is as easy as shading- I didn’t want to try to fiddle with replacing the whole structure of the logic to use the cached string values.

codefromthecrypt commented 5 years ago

0.15.2 on the way