openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

SQS Message Propagation Injection #124

Closed devinsba closed 5 years ago

devinsba commented 5 years ago

This is an implementation of SQS message propagation injection using the RequestHandler2 methods in order to avoid client wrapping. Still needs an integration test but I wanted to get eyes on it.

This is modeled after the Brave Rabbit instrumentation and the work in smartthings-brave

devinsba commented 5 years ago

It does work. I have this code in 3 repos at the moment actually, it's been tested in our apps in the other 2. It hasn't been put in prod yet but I don't see anything I'm worried about.

devinsba commented 5 years ago

@llinder please review at your leisure