Makes integration tests run and fixes some of the awsv2 bugs

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud

Apache License 2.0

69 stars 34 forks source link

Makes integration tests run and fixes some of the awsv2 bugs #128

Closed codefromthecrypt closed 5 years ago

codefromthecrypt commented 5 years ago

We had a blind spot I think reported before by @devinsba. Our integration tests didn't run.

devinsba commented 5 years ago

Fixes #126

devinsba commented 5 years ago

I wondered why I hadn't seen that flaky SQS test in a while..

codefromthecrypt commented 5 years ago

hehe

On Thu, Mar 28, 2019, 5:24 PM Brian Devins-Suresh notifications@github.com wrote:

I wondered why I hadn't seen that flaky SQS test in a while..

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/pull/128#issuecomment-477533217, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD61wzjUpe0w2fxHO07097kGs0k4e1Qks5vbJgogaJpZM4cPwMh .

codefromthecrypt commented 5 years ago

finally green. bye circleci.. hello again travis