Closed SerCeMan closed 5 years ago
Hey, @devinsba! Thanks for merging. In our case, there is no specific instrumentation, we add these tags manually when an instance of tracer is constructed, similar to the following:
.addFinishedSpanHandler(new FinishedSpanHandler() {
@Override
public boolean handle(TraceContext context, MutableSpan span) {
if (instanceId != null) {
span.tag("aws.ec2.instance_id", instanceId);
}
// ...
return true;
}
})
Ok, looks about like what I was planning to implement at some point. I'll ping you when I build it to see if you have anything I missed
This PR implements support for the EC2 section of the AWS segment in the X-Ray span metadata.
As a result, X-Ray is able to regognise the tag as a special tag instead of having it as an annotation.