search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Migrate storage-elasticsearch-aws to use new armeria version. #134

Closed anuraaga closed 5 years ago

anuraaga commented 5 years ago

Ready for review but leaving as draft since it's currently set for jitpack for testing.

codefromthecrypt commented 5 years ago

this was missing aws date header but after I added that amazon whined about signature match. I will check later about it

On Tue, Jul 16, 2019, 4:34 PM Anuraag Agrawal notifications@github.com wrote:

@anuraaga https://github.com/anuraaga requested your review on: #134 https://github.com/openzipkin/zipkin-aws/pull/134 Migrate storage-elasticsearch-aws to use new armeria version..

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/pull/134?email_source=notifications&email_token=AAAPVV6VIGNJHTQEPCBUWZ3P7V2WZA5CNFSM4ID56CU2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSQQNEJY#event-2485178919, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAPVV7JNCK2VVOTVX3H7W3P7V2WZANCNFSM4ID56CUQ .

codefromthecrypt commented 5 years ago

somehow I lost push access so I opened a new branch https://github.com/openzipkin/zipkin-aws/pull/135