search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

SQS Reporter V2 SDK #140

Closed llinder closed 5 years ago

llinder commented 5 years ago

When projects are already importing the V2 AWS SDK for other things, it would be nice to have the option of using V2 SDK for the SQS reporter as well. Besides not inflating the project dependencies, reportedly important V1 and V2 in the same project produces conflicts.

codefromthecrypt commented 5 years ago

totally agree. I was thinking the same thing. Also the collectors have no reason to be v1 as we have no reason to re-use classes from them or retain compatibility.

devinsba commented 5 years ago

+1 the collectors should really be updated to V2 since the server is now netty based, we can remove that unneeded dependency of another http library

On Mon, Aug 19, 2019 at 8:37 PM Adrian Cole notifications@github.com wrote:

totally agree. I was thinking the same thing. Also the collectors have no reason to be v1 as we have no reason to re-use classes from them or retain compatibility.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/issues/140?email_source=notifications&email_token=AABCFITI3BDD3HLTPBWJKMDQFM4FBA5CNFSM4ING7XN2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4UWD5Y#issuecomment-522805751, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCFIV3QTYFPMY5WQLXU23QFM4FBANCNFSM4ING7XNQ .

llinder commented 5 years ago

Updating the collector makes sense. I will open a new issue and MR once the sender side of things is done.