openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Make edge-case behavior nice for elasticsearch service on AWS #142

Open codefromthecrypt opened 8 years ago

codefromthecrypt commented 8 years ago

@devinsba noticed the error handling wasn't right when his account was missing permissions for elasticsearch. We should note in the readme (well create a readme first and note) the IAM permissions needed. Let's add a error nicer than NPE when it isn't there.

There was also a report of a hang on a newly provisioned cluster. This might be a smell of an infinite socket or otherwise timeout. Something to look into.

cc @sethp-jive

codefromthecrypt commented 8 years ago

going to raise a pull request to fix something I messed up, more importantly carving out a unit test as doing the first one is usually the hard part.

codefromthecrypt commented 5 years ago

not sure if this is a problem still