search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Updates to zipkin 2.18 and fixes region config #146

Closed codefromthecrypt closed 4 years ago

codefromthecrypt commented 4 years ago

SQS region config wasn't read due to missing bean getter/setter Elasticsearch wasn't reading AWS_REGION

Also note for those who had older zipkin images, that if you mounted a volume for AWS creds, the docker image is home '/zipkin' not '/root'!

@llinder not sure if any of the above could have been problems for you recently

codefromthecrypt commented 4 years ago

@anuraaga I tested by building like this

 docker build -t openzipkin/zipkin-aws:test -f docker/Dockerfile .

and then running like this:

docker run -e SQS_QUEUE_URL=https://ap-southeast-1.queue.amazonaws.com/012345678901/zipkin -e ES_AWS_DOMAIN=zipkin-ha -e STORAGE_TYPE=elasticsearch -e AWS_REGION=ap-southeast-1 -v $HOME/.aws:/zipkin/.aws:ro  -p 9411:9411 openzipkin/zipkin-aws:test
codefromthecrypt commented 4 years ago

git push origin release-0.19.0