search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

NPE fix for #147 #148

Closed wavetylor closed 4 years ago

wavetylor commented 4 years ago

Issue: #147

When an s3 client is configured with the option enableForceGlobalBucketAccess(), the sdk makes some internal requests that don't properly setup a parent span usually named aws-sdk.

Unfortunately, I wasn't able to figure out a way to tie the "orphaned" request spans back to the original parent application spans, so null checks was the best I could do here.

codefromthecrypt commented 4 years ago

hell of a NPE fix :) 💯

wavetylor commented 4 years ago

Thanks for the reviews!