search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Remove port from authority header since we remove it when signing. #164

Closed anuraaga closed 4 years ago

anuraaga commented 4 years ago

Every other release of Armeria seems to have different behavior with regards to authority header /cc @trustin

Fixes #152

trustin commented 4 years ago

Doh! Sorry about the inconveniences. What would be the most sensible behavior?

anuraaga commented 4 years ago

@trustin Here we had some discrepency because of initializing using Endpoint instead of a String.

https://github.com/openzipkin/zipkin-aws/blob/ccf5775c61ed798c8ff5cbc416f59369fca1a4fd/module/storage-elasticsearch-aws/src/main/java/zipkin/module/storage/elasticsearch/aws/ZipkinElasticsearchAwsStorageModule.java#L69

Not sure what's the best - but I think the behavior changed between versions, and I guess most important is that it doesn't change :)