search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Add optional origin field #171

Closed iamsouravin closed 4 years ago

iamsouravin commented 4 years ago
iamsouravin commented 4 years ago

Thanks @adriancole and @anuraaga for the review comments. Incorporated the suggested changes.

Deferring the auto-detection piece for a later thread as discussed with @anuraaga since it involves a larger discussion with the general community integration with other projects like OpenTelemetry.

codefromthecrypt commented 4 years ago

I accidentally closed this somehow and sadly can't re-open it. I will cherry-pick the changes in!

codefromthecrypt commented 4 years ago

200206f and opened #172 for follow-up. thanks @iamsouravin and @anuraaga