search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Upgrade Zipkin and Log4j #193

Closed enriquerecarte closed 2 years ago

enriquerecarte commented 2 years ago

This PR upgrades Zipkin to the latest version, which solves the Log4j vulnerability. It also upgrades the log4j version used for the tests

enriquerecarte commented 2 years ago

@adriancole, any chance you could take a look at this one?

jcchavezs commented 2 years ago

I will look into it today.

On Fri, Dec 17, 2021, 11:04 Enrique Recarte @.***> wrote:

@adriancole https://github.com/adriancole, any chance you could take a look at this one?

— Reply to this email directly, view it on GitHub https://github.com/openzipkin/zipkin-aws/pull/193#issuecomment-996590429, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAXOYASTJRAG35XYUMVJKDTURMDLBANCNFSM5KIODWYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

jcchavezs commented 2 years ago

The deploy is failing so we can't release yet. I am looking into that but not sure how many cycles I got. We should definitively check if this step is part of the CI https://github.com/openzipkin/zipkin-aws/runs/4580017105?check_suite_focus=true#step:4:2291