Closed codefromthecrypt closed 6 months ago
@reta if you have free time, do you mind trying to progress this? While the project is zipkin-aws proceeding doesn't need an aws account. There is some work to do porting off junit 4 environment rule and also figuring out why the mock sqs setup I tried to port to jupiter doesn't work. It is fine to use a different sqs mock or even a docker testcontainer instead. Push any commits you like and feel free to do anything including force pushing or squashing. When you've moved as far as you can, please summarize in a comment, even if incomplete still. Cheers!
@reta if you have free time, do you mind trying to progress this?
Sure @codefromthecrypt , I will work on it
nice to see some commits going 🙇♂️
@codefromthecrypt it seems like we are in good shape :-) anything else you have in mind for this change?
@reta so when we merge, we always squash and retain co-author tags, but tidy up the message so it isn't like a list of interim commits. Over to you for the release and looking forward to you pinging it on the zipkin gitter channel, too when done. :shipit: 🚀
@reta ps one thing in RELEASE.md it says for the first release of the year, make sure the pom.xml license headers are up to date. If they aren't the release will fail. so you want to do something like this to make sure they are bumped.. or check manually https://github.com/openzipkin/zipkin-aws/blob/master/RELEASE.md#first-release-of-the-year
This moves to the same build infra as the rest of Zipkin, notably to allow compiling on JDK 11, 17 and 21. This also bumps all the dependencies and ports to junit jupiter (used by brave now).
This also migrates to junit5 which began with the helpful @TeamModerne tool, but needed a lot of fixing up due to custom rules.
I intentionally raised this on a shared branch as I'm out of time. If someone can finish up the rest of it, many thanks. Notably, I think I messed up porting the SQS extension (some tests pass some hang). Also, there's a need to replace the environment rule with something. Pinging @timetebeek, but really anyone who is good at jupiter could give a swing and let this project release again after merge!