search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Sender for kinesis #41

Closed devinsba closed 7 years ago

devinsba commented 7 years ago

Not a huge user of autovalue so I pretty much copied the impl from sender-sqs. Please comment if there are issues. IntelliJ doesn't like it but it compiles, so..

Closes #16

codefromthecrypt commented 7 years ago

ok base test is working (needed to cbor decode the payload) you can add any more you see fit now. once readme etc polish is in, let's merge time!

devinsba commented 7 years ago

Thanks for tracking it down. I've never even heard of CBOR before now

devinsba commented 7 years ago

That approach is certainly much nicer. Thanks for sharing it :+1: