search

openzipkin / zipkin-aws

Reporters and collectors for use in Amazon's cloud
Apache License 2.0
69 stars 34 forks source link

Does'nt work with AWS SQS FIFO queue #62

Closed raevilman closed 6 years ago

raevilman commented 6 years ago

Zipkin SQSSender doesn't work with AWS SQS FIFO queue

Throws following exception in AsyncReporter at this.sender.sendSpans(nextMessage).execute();

com.amazonaws.services.sqs.model.AmazonSQSException: The request must contain the parameter MessageGroupId. (Service: AmazonSQS; Status Code: 400; Error Code: MissingParameter; Request ID: 82b6a6cc-c2e8-5905-b27e-f45be9c97ea0)

devinsba commented 6 years ago

Zipkin's data store and model is designed to handle out of order span delivery and the senders do not guarantee order, this would be a feature without a purpose due to these reasons.

raevilman commented 6 years ago

Totally agree with @devinsba We can ignore/close this with proper mention of not supporting FIFO queues in README